Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position of "0" in selection vs pencil grid don't match #157

Closed
drkthomp opened this issue Apr 21, 2024 · 5 comments
Closed

Position of "0" in selection vs pencil grid don't match #157

drkthomp opened this issue Apr 21, 2024 · 5 comments
Assignees
@meikpiep
Labels
enhancement New feature or request

Comments

@drkthomp
Copy link

In the pencil mark grid, 0 is first, whereas in the selection bar it is last. Feature wise I would prefer if it were first or if there was an option to decide, but not matching at all seems like a bug.

Screenshot_20240421-224137_Gauguin

(Also love this game!)
@meikpiep meikpiep added the enhancement New feature or request label Apr 23, 2024
@meikpiep
Copy link
Owner

meikpiep commented May 4, 2024

Sorry for the delay - the inconsistency is definitely a bad thing. I have no definite opinion which way round would be best and want to avoid another option.

I will try to play a few such games to get a feeling.

@meikpiep meikpiep self-assigned this May 12, 2024
meikpiep added a commit that referenced this issue May 12, 2024
@meikpiep
Let pencil marks in 3x3 mode be consistent with the key pad numbers
afcabd9 
Includes updated and two additional screenshot tests to verify the result.

Solves issue #157.
@meikpiep
Copy link
Owner

I got to the opinion that the 3x3 pencil marks should follow the key pad layout, so it will look like this:

grafik

I think the "1-2-3" in the first line of the key pad is a common settings to be preserved, but let's see what the other users mean.

@meikpiep
Copy link
Owner

A 7x7 sample will make it more clear:

grafik

@meikpiep meikpiep mentioned this issue May 12, 2024
Merged
meikpiep added a commit that referenced this issue May 12, 2024
@meikpiep
Let pencil marks in 3x3 mode be consistent with the key pad numbers (#…
9c32dde 
…166)

Includes updated and two additional screenshot tests to verify the result.

Solves issue #157.
@meikpiep
Copy link
Owner

meikpiep commented May 12, 2024 •
edited

Just merged the changes, will get into the next release - feel free to add feedback.

@meikpiep
Copy link
Owner

FYI: I optimized the layout a bit, see here:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meikpiep meikpiep

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drkthomp @meikpiep