Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting consistency #1124

Closed
MarinPostma opened this issue Dec 8, 2020 · 0 comments · Fixed by #1128
Closed

Fix setting consistency #1124

MarinPostma opened this issue Dec 8, 2020 · 0 comments · Fixed by #1128
Assignees
Labels
bug Something isn't working as expected tracking issue Tracks development of a global issue

Comments

@MarinPostma
Copy link
Contributor

Summary

There are currently two bugs that need to be addressed regarding setting consistency. The first one concerns the behavior of the wildcard in searchableAttributes and displayedAttributes as thourougly described in #761.
The second is regarding the indexing position of fields registered in the setting before document addition, where the said field are given a position that is not consistent with the order in which they appear in the documents.

Motivations

This will overall improve consistency of the settings and user experience.

Explanation

The idea is to add new fields registered in the settings only in the FieldMap (known fields) and not in the IndexedPosition map, until they are first discovered in a document, and give them a IndexedPosition only then.

The searchableAttributes and displayedAttributes should rely exclusively on the fields present in the IndexedPosition map, when the value is a wildcard.

Related

This is a bug fix and does not have an impact on the documentation

@MarinPostma MarinPostma added bug Something isn't working as expected tracking issue Tracks development of a global issue labels Dec 8, 2020
@MarinPostma MarinPostma self-assigned this Dec 8, 2020
@bors bors bot closed this as completed in 446b2e7 Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected tracking issue Tracks development of a global issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant