Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the deletion of tmp_nodes #60

Closed
irevoire opened this issue Jan 15, 2024 · 0 comments · Fixed by #62
Closed

Improve the deletion of tmp_nodes #60

irevoire opened this issue Jan 15, 2024 · 0 comments · Fixed by #62
Labels
indexing Everything related to indexing performance

Comments

@irevoire
Copy link
Member

Sometimes we need to delete new nodes previously inserted in the tmp_nodes.
From my understanding, it was always either the last one or the last last one, but it looks like it's not.

It would be good to check measure if we often do a lot of iterations, and if that's the case try to optimize it.

if let Some(el) = self.ids.iter_mut().rev().take(2).find(|i| **i == item) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
indexing Everything related to indexing performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant