Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fuzzer #57

Merged
merged 6 commits into from Jan 16, 2024
Merged

Add a fuzzer #57

merged 6 commits into from Jan 16, 2024

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Jan 15, 2024

Pull Request

Add a very basic fuzzer on arroy:

  • The fuzzer is located in examples/fuzz.rs
  • I added the fuzzer in the CI, and it runs for 5 minutes
  • While fuzzing arroy, I found and fixed two bugs on the incremental indexing PR that was just merged:
    • Calling build when there are no vectors in the database was triggering a division by zero in the remove_extraneous_trees method
    • In some cases, the newly crafted left and right children of a split node were not in the two last positions in the tmp_nodes. Now we check the whole list of tmp_nodes when we need to delete something, but still from the end since it's related to the latest nodes creations.

@irevoire irevoire added bug Something isn't working maintenance Related to maintenance labels Jan 15, 2024
@irevoire irevoire merged commit 73d2efb into main Jan 16, 2024
8 checks passed
@irevoire irevoire deleted the add-a-fuzzer branch January 16, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Related to maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants