Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge after #37
Related to #5
We could probably improve the search performance by a lot by storing in every split node all the IDs below it and choosing the branch accordingly.Tested and failed in #39While filtering out half of the items:
Louis's query got twice faster, and the fastest query also got way faster than before.
But the slowest and average are pretty much the same as before.
Without filtering anything (just to see the impact of deserializing roaring bitmap on every descendants):
Compared to main before this PR:
In term of database size we won ~10% on movies: