Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to check if Writer::clear works #66

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Feb 29, 2024

The PR fixes #65 by ignoring the value/data when we iterate through the database subset entries to clear a database. It was previously trying to read the entries by using the NodeCodec<D: Distance> and wasn't able to deserialize some metadata entries.

@Kerollmops Kerollmops added the bug Something isn't working label Feb 29, 2024
@Kerollmops Kerollmops marked this pull request as ready for review February 29, 2024 10:58
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto thanks!

@irevoire irevoire merged commit 9283482 into main Feb 29, 2024
8 checks passed
@irevoire irevoire deleted the fix-writer-clear branch February 29, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The clear function throw a panic
2 participants