Panic at search when the trees need a rebuild #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
added
bug
Kerollmops
requested changes
Jun 20, 2024
irevoire
force-pushed
the
panic-at-search
branch
from
2537472
to
95e0609
Compare
Co-authored-by: Clément Renault <clement@meilisearch.com>
irevoire
force-pushed
the
panic-at-search
branch
from
95e0609
to
ae9e854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #74
What does this PR do?
updateditem list instead of emptying itWriterto know if we need to build the tree or can simply drop the writer