-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The chinese-normalization-pinyin
feature flag doesn't compile
#290
Comments
Just to be clear, what's expected here is the new CI command i.e. |
I made a mistake when putting |
Hey @ManyTheFish! Waiting for your review to this above PR by @tkhshtsh0917. I actually doubt whether that's the complete solution. Because even after that if you run |
Hi @Soham1803! I would like to properly understand your thoughts, are you arguing that we should use a trick where only the features specified in Like this? |
Hello @Soham1803 and @tkhshtsh0917, you are right. The number of tests doesn't change; however, they are not exactly the same. In the Chinese normalizer tests the expected result change depending on the feature flag. Whit your PR, both sides will be tested. |
Oh yes! I get it now. Thanks @ManyTheFish for clearing my doubt and all the best @tkhshtsh0917 with your PR. 😊 |
Reproduction
cargo test --verbose --features chinese-normalization-pinyin
Fix
cargo test --verbose --features chinese-normalization-pinyin
instead ofcargo test --verbose --features chinese chinese-normalization-pinyin
related to meilisearch/meilisearch#4629
The text was updated successfully, but these errors were encountered: