Implement the CharNormalizer trait on the LowercaseNormalizer struct #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #239
What does this PR do?
CharNormalizer
forLowercaseNormalizer
Normalizer
trait implementationchar_map
field on the producedToken
PR checklist
Please check if your PR fulfills the following requirements:
CharNormalizer
trait on theLowercaseNormalizer
struct #239, it leads to a correctly populatedchar_map
Some quick notes
I based my implementation on
CompatibilityDecompositionNormalizer
.This leads to duplicated code. I considered adding a function that both implementations could share, if that seems more appropriate, I can propose an alternate solution.