Make the pinyin-normalization optional #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ManyTheFish
commented
Apr 17, 2024
ManyTheFish
commented
- split the Chinese feature flag in order to deactivate a part of the pipeline
- remove pinyin normalization from the default pipeline
Kerollmops
approved these changes
Apr 17, 2024
Comment on lines
+43
to
+46
| chinese = ["chinese-segmentation", "chinese-normalization"] | ||
| chinese-segmentation = ["dep:jieba-rs"] | ||
| chinese-normalization = [] | ||
| chinese-normalization-pinyin = ["dep:pinyin", "chinese-normalization"] |
There was a problem hiding this comment.
Will you reflect that on Meilisearch, too?
There was a problem hiding this comment.
no, I don't think so,
everybody complains about this normalizer but I keep it in case another user of charabia wants to keep it
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.