Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all region to spread AWS image and make it public #15

Merged
merged 4 commits into from May 9, 2023
Merged

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Apr 25, 2023

Fixes #8

@alallema alallema linked an issue Apr 26, 2023 that may be closed by this pull request
@alallema alallema mentioned this pull request May 1, 2023
Closed
16 tasks
Comment on lines 38 to 57
"us-east-1",
"us-east-2",
"us-west-1",
"us-west-2",
"af-south-1",
"ap-east-1",
"ap-south-1",
"ap-northeast-2",
"ap-southeast-1",
"ap-southeast-2",
"ap-northeast-1",
"ca-central-1",
"eu-central-1",
"eu-west-1",
"eu-west-2",
"eu-south-1",
"eu-west-3",
"eu-north-1",
"me-south-1",
"sa-east-1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"us-east-1",
"us-east-2",
"us-west-1",
"us-west-2",
"af-south-1",
"ap-east-1",
"ap-south-1",
"ap-northeast-2",
"ap-southeast-1",
"ap-southeast-2",
"ap-northeast-1",
"ca-central-1",
"eu-central-1",
"eu-west-1",
"eu-west-2",
"eu-south-1",
"eu-west-3",
"eu-north-1",
"me-south-1",
"sa-east-1",
"ap-east-1",
"ap-northeast-1",
"ap-northeast-2",
"ap-northeast-3",
"ap-south-1",
"ap-south-2",
"ap-southeast-1",
"ap-southeast-2",
"ap-southeast-3",
"ap-southeast-4",
"ca-central-1",
"cn-north-1",
"cn-northwest-1",
"eu-central-1",
"eu-central-2",
"eu-north-1",
"eu-south-1",
"eu-south-2",
"eu-west-1",
"eu-west-2",
"eu-west-3",
"me-central-1",
"me-south-1",
"sa-east-1",
"us-east-1",
"us-east-2",
"us-gov-east-1",
"us-gov-west-1",
"us-west-1",
"us-west-2"

Here is the updated regions list :)

Copy link
Contributor Author

@alallema alallema May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !
But I think we don't have access to it instead, we modify it:

There are 6 Regions that are not enabled for this account:
ap-south-2
ap-southeast-3
ap-southeast-4
eu-south-2
eu-central-2
me-central-1

Did we make the modification on the AWS account before?

I can find these 4 regions:

cn-north-1
cn-northwest-1
us-gov-east-1
us-gov-west-1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've enabled the remaining ones into our account, it take some minutes in order to make it work :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge it now, and then check in the next release if all of the regions are available correctly!

@brunoocasali brunoocasali added the enhancement New feature or request label May 9, 2023
@alallema alallema requested a review from brunoocasali May 9, 2023 16:35
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alallema alallema merged commit 397d727 into main May 9, 2023
1 check passed
@alallema alallema deleted the aws-region branch May 9, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] Add every region [AWS] Image private to public
2 participants