Transform for loops into forEach

meilisearch · Jan 6, 2021 · d1d382d · d1d382d
1 parent 458a627
commit d1d382d
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/setup/setup.js b/setup/setup.js
@@ -93,12 +93,13 @@ const rankingRulesDesc = [
   // Add documents
   const batchedDataSet = batch(processedDataSet, 10000)
   console.log('Adding documents...')
-  for (let i = 0; i < batchedDataSet.length; i++) {
-    const { updateId } = await index.addDocuments(batchedDataSet[i])
+  batchedDataSet.forEach(async (batch) => {
+    const { updateId } = await index.addDocuments(batch)
     await index.waitForPendingUpdate(updateId, {
       timeOutMs: 100000
     })
-  }
+  })
+
   console.log('Documents added to "artWorks" index.')
 
   // ArtWorks with ASC order
@@ -108,12 +109,12 @@ const rankingRulesDesc = [
   console.log('Settings added to "artWorksAsc" index.')
 
   console.log('Adding documents...')
-  for (let i = 0; i < batchedDataSet.length; i++) {
-    const { updateId } = await indexAsc.addDocuments(batchedDataSet[i])
-    await indexAsc.waitForPendingUpdate(updateId, {
+  batchedDataSet.forEach(async (batch) => {
+    const { updateId } = await indexAsc.addDocuments(batch)
+    await index.waitForPendingUpdate(updateId, {
       timeOutMs: 100000
     })
-  }
+  })
   console.log('Documents added to "artWorksAsc" index.')
 
   // ArtWorks with DESC order
@@ -122,12 +123,12 @@ const rankingRulesDesc = [
   await indexDesc.updateSettings(settings)
   console.log('Settings added to "artWorksDesc" index.')
   console.log('Adding documents...')
-  for (let i = 0; i < batchedDataSet.length; i++) {
-    const { updateId } = await indexDesc.addDocuments(batchedDataSet[i])
-    await indexDesc.waitForPendingUpdate(updateId, {
+  batchedDataSet.forEach(async (batch) => {
+    const { updateId } = await indexDesc.addDocuments(batch)
+    await index.waitForPendingUpdate(updateId, {
       timeOutMs: 100000
     })
-  }
+  })
   console.log('Documents added to "artWorksDesc" index.')
 })()