Refactor code

setup/setup.js

@@ -84,12 +84,12 @@ const defaultRankingRules = [
   const artWorksAscIndex = await client.getOrCreateIndex('artWorksAsc', { primaryKey: 'ObjectID' })
   const artWorksDescIndex = await client.getOrCreateIndex('artWorksDesc', { primaryKey: 'ObjectID' })
 
-  // Check if index are populated and populate them is needed
-  const artWorks = { name: 'artWorks', index: artWorksIndex, rules: defaultRankingRules }
-  const artWorksAsc = { name: 'artWorksAsc', index: artWorksAscIndex, rules: rankingRulesAsc }
-  const artWorksDesc = { name: 'artWorksDesc', index: artWorksDescIndex, rules: rankingRulesDesc }
-
-  const indexArray = [artWorks, artWorksAsc, artWorksDesc]
+  // Create Indexes array
+  const indexArray = [
+    { name: 'artWorks', index: artWorksIndex, rules: defaultRankingRules },
+    { name: 'artWorksAsc', index: artWorksAscIndex, rules: rankingRulesAsc }, 
+    { name: 'artWorksDesc', index: artWorksDescIndex, rules: rankingRulesDesc }
+  ]
 
   for (const index of indexArray) {
     const isPopulated = await indexIsPopulated(index.index, dataset)
@@ -172,9 +172,5 @@ async function populateIndex ({ index, rules, name }, batchedDataSet) {
 
 async function indexIsPopulated (index, dataset) {
   const indexStats = await index.getStats()
-  if (indexStats.numberOfDocuments === dataset.length) {
-    return true
-  } else {
-    return false
-  }
+  return indexStats.numberOfDocuments === dataset.length
 }