Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Meilisearch wording in the README.md #42

Merged

Conversation

nicolasvienot
Copy link
Member

@nicolasvienot nicolasvienot commented Apr 21, 2022

Pull Request

What does this PR do?

Fixes #35

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

⚠️ This is also a test for the Vercel integration (rights needed for the tenant-token demo when creating a PR)

@vercel
Copy link

vercel bot commented Apr 21, 2022

@nicolasvienot is attempting to deploy a commit to the Meili Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
demo-finding-crates ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 6:40AM (UTC)
demo-finding-pypi ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 6:40AM (UTC)
demo-finding-rubygems ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 6:40AM (UTC)
demo-geo-javascript ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 6:40AM (UTC)
demo-moma ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 6:40AM (UTC)
demo-nobel-prizes ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 6:40AM (UTC)
demo-tenant-token ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 6:40AM (UTC)

@ferdi05
Copy link
Contributor

ferdi05 commented Apr 21, 2022

Thanks @nicolasvienot !!

@shivaylamba when you have fixed the issue with the tenant token demo, let's merge this

@nicolasvienot
Copy link
Member Author

nicolasvienot commented Apr 21, 2022

Hey @ferdi05,
I investigated for #43 and left a comment there, I think this should fix your problem with the Vercel – demo-tenant-token GitHub check 😄

@CaroFG
Copy link
Contributor

CaroFG commented May 30, 2022

Any updates?

@ferdi05
Copy link
Contributor

ferdi05 commented May 30, 2022

cc @shivaylamba I didn't check the results of the test

@shivaylamba
Copy link
Contributor

Hi so I have made all the relevant changes as suggested by @nicolasvienot so ideally this should work fine now.

@CaroFG CaroFG merged commit c98f35f into meilisearch:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of Meilisearch instead of MeiliSearch in the README
4 participants