Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements to field attributes #7

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Various improvements to field attributes #7

merged 4 commits into from
Jan 10, 2023

Conversation

loiclec
Copy link
Contributor

@loiclec loiclec commented Jan 10, 2023

  1. Add skip attribute to avoid deserialising certain fields
  2. Fix bug in the contraints generated by the from field attribute
  3. Change argument to missing_field_error field attribute from an expression to a function path
  4. Use the field's custom error type to merge the error generated by the from attribute

@irevoire irevoire merged commit bd75724 into main Jan 10, 2023
@irevoire irevoire deleted the field-attrs branch January 10, 2023 14:58
@irevoire irevoire mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loiclec @irevoire