-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.3: Experimental API route #2482
Comments
@dureuill, question: Changes made to an experimental feature using the API persist between launches. For example, if I activate vector search via the API, that feature will still be active after I interrupt and relaunch an instance. What happens when changes made via the API conflict with e.g. a cli flag? For example, if I launch Meilisearch with |
@dureill, another question on the interaction between experimental options and experimental API. Do cli flags/env vars mark an experimental feature as active in the API? For example, if I launch Meilisearch with |
Hello @guimachiavelli, We sidestepped this issue by making it so that features that can be toggled at runtime cannot be enabled by a command line flag, a configuration setting or an environment variable. The PRD states "No CLI/env variable for the corresponding exp features" |
duh, sorry, I missed that. Thanks for pointing it out 🙏 |
You're welcome! It was a good question, hence why we decided to not answer it right away in this first iteration |
Ok, another question, which I hopefully have not missed from the PR nor the PRD. From what I'm seeing, we have implemented a |
hmmm, I think we don't have a good reason to provide a |
3699: Search for Facet Values r=dureuill a=Kerollmops This PR introduces the first version of [the _Search for Facet Values_ feature](https://github.com/meilisearch/product/discussions/515) that allows a user to search for facets, by optionally using a prefix string and optionally specifying the `q` and `filter` original search parameters to restrict the candidates to search in. The steps to merge it into Meilisearch will first start by providing prototype Docker images. This way users will be able to test the prototypes before using them. The current route to use the _Search for Facet Values_ feature is the `POST /indexes/{index}/facet-search` where the body is a JSON object that looks like the following: ```json5 { "q": "spiderman", // optional "filter": "rating > 10", // optional "facetName": "genres", "facetQuery": "a" // optional } ``` ## What is missing? - [x] Send some analytics. - [x] Support the `matchingStrategy` parameter. - [x] Make sure that the errors are the right ones. - [x] Use the [Index typo tolerance settings](https://www.meilisearch.com/docs/learn/configuration/typo_tolerance#minwordsizefortypos) when matching facet values. - [x] minWordSizeForTypos.oneTypo - [x] minWordSizeForTypos.twoTypo - [x] Add tests - [x] Log the time it took to compute the results. - [x] Fix the compilation warnings. - [x] [Create an issue to fix potential performance issues when indexing](#3862). 3864: Remove `/experimental-features` verbs that weren't in the PRD r=Kerollmops a=dureuill Removes: - POST `/experimental-features` - DELETE `/experimental-features` keeping only: - PATCH `/experimental-features` - GET `/experimental-features` The two routes that are described in the PRD. Following `@guimachiavelli's` [question](meilisearch/documentation#2482 (comment)) about the POST route. Co-authored-by: Clément Renault <clement@meilisearch.com> Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: Louis Dureuil <louis@meilisearch.com>
3864: Remove `/experimental-features` verbs that weren't in the PRD r=dureuill a=dureuill Removes: - POST `/experimental-features` - DELETE `/experimental-features` keeping only: - PATCH `/experimental-features` - GET `/experimental-features` The two routes that are described in the PRD. Following `@guimachiavelli's` [question](meilisearch/documentation#2482 (comment)) about the POST route. Co-authored-by: Louis Dureuil <louis@meilisearch.com>
The engine team is working on creating a new API route to manage experimental features without the need for CLI flags and environment variables. The aim is to make it easier for users to turn experimental features on and off, something which will also benefit Meiliearch's cloud offering.
Not all experimental features will be editable via the new endpoint. We won't havetime to implement an interface for some (e.g.
/metrics
endpoint), and it is impossible to use the API to manage others (e.g.--experimental-reduce-indexing-memory-usage
).Tasks
References
The text was updated successfully, but these errors were encountered: