Remove MeiliSearch dataset dependency #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for distracted-wiles-3edfc5 ready! 🔨 Explore the source changes: 34dc093 🔍 Inspect the deploy log: https://app.netlify.com/sites/distracted-wiles-3edfc5/deploys/6166fc483c3a9d0008058a83 😎 Browse the preview: https://deploy-preview-1109--distracted-wiles-3edfc5.netlify.app |
This was referenced Sep 10, 2021
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 13, 2021
1109: Remove MeiliSearch dataset dependency r=guimachiavelli a=curquiza Remove the links coming from the dataset contained in the MeiliSearch's repository: https://github.com/meilisearch/MeiliSearch/tree/main/datasets/movies So that we can merge: meilisearch/meilisearch#1693 Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: gui machiavelli <gui@meilisearch.com>
|
Canceled. |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 13, 2021
1109: Remove MeiliSearch dataset dependency r=guimachiavelli a=curquiza Remove the links coming from the dataset contained in the MeiliSearch's repository: https://github.com/meilisearch/MeiliSearch/tree/main/datasets/movies So that we can merge: meilisearch/meilisearch#1693 Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: gui machiavelli <gui@meilisearch.com>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
guimachiavelli
approved these changes
Oct 13, 2021
|
bors merge |
|
Build succeeded: |
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Oct 14, 2021
1693: Remove dataset r=Kerollmops a=curquiza Fixes #1230⚠️ Should be merged once meilisearch/documentation#1109 is merged!⚠️ Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the links coming from the dataset contained in the MeiliSearch's repository: https://github.com/meilisearch/MeiliSearch/tree/main/datasets/movies
So that we can merge: meilisearch/meilisearch#1693