Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.9: Add new retrieveVectors and _vectors behaviour #2876

Merged
merged 14 commits into from
Jun 27, 2024
Merged

v1.9: Add new retrieveVectors and _vectors behaviour #2876

merged 14 commits into from
Jun 27, 2024

Conversation

guimachiavelli
Copy link
Member

Closes #2857

@meili-bot
Copy link
Collaborator

How to see the preview of this PR?

⚠️ Private link, only accessible to Meilisearch employees.

Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:v1.9-vector-search

Credentials to access the page are in the company's password manager as "Docs deploy preview".

@guimachiavelli guimachiavelli mentioned this pull request Jun 18, 2024
Closed
@guimachiavelli guimachiavelli marked this pull request as ready for review June 19, 2024 12:10
@guimachiavelli guimachiavelli requested a review from a team as a code owner June 19, 2024 12:10
@curquiza
Copy link
Member

Approval for code samples 👆

dureuill
dureuill requested changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello ☀️

I suggested fixes for a few errors. I believe retrieveVectors also needs documenting for the similar route and the fetch documents route(s).

reference/api/documents.mdx Outdated Show resolved Hide resolved
reference/api/documents.mdx Outdated Show resolved Hide resolved
reference/api/documents.mdx Outdated Show resolved Hide resolved
reference/api/documents.mdx Outdated Show resolved Hide resolved
reference/api/documents.mdx Outdated Show resolved Hide resolved
reference/api/documents.mdx Outdated Show resolved Hide resolved
reference/api/documents.mdx Outdated Show resolved Hide resolved
reference/api/search.mdx Outdated Show resolved Hide resolved
@guimachiavelli guimachiavelli linked an issue Jun 20, 2024 that may be closed by this pull request
v1.9: AI-powered search updates #2857
Closed
2 tasks
@guimachiavelli guimachiavelli mentioned this pull request Jun 25, 2024
Merged
dureuill
dureuill reviewed Jun 25, 2024
View reviewed changes
reference/api/search.mdx Show resolved Hide resolved
reference/api/documents.mdx Outdated Show resolved Hide resolved
reference/api/documents.mdx Outdated Show resolved Hide resolved
reference/api/documents.mdx Outdated Show resolved Hide resolved
dureuill
dureuill approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few final comments but we're definitely converging

reference/api/documents.mdx Outdated Show resolved Hide resolved
reference/api/search.mdx Outdated Show resolved Hide resolved
guimachiavelli and others added 2 commits June 27, 2024 12:20
@guimachiavelli @dureuill
Apply suggestions from code review
f6113da 
Co-authored-by: Louis Dureuil <louis.dureuil@gmail.com>
@guimachiavelli
include _vectors example
e465ba0
@guimachiavelli guimachiavelli merged commit dca2713 into v1.9 Jun 27, 2024
1 check passed
@guimachiavelli guimachiavelli deleted the v1.9-vector-search branch June 27, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

@dureuill dureuill Awaiting requested review from dureuill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.9: AI-powered search updates
4 participants
@guimachiavelli @meili-bot @curquiza @dureuill