Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stale] Compare identical environments by using a same_file::Handle #179

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

[Stale] Compare identical environments by using a same_file::Handle #179

wants to merge 11 commits into from

Commits on Jul 10, 2023

  1. Check env file already open with samefile. 

    Samefile abstract away differences between Unixes and windows to check
if two files lead to the same file on the underlying filesystem.

Now it should follow through soft-links, hard-links and file moved.
    @darnuria
    darnuria committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    e880cf7 View commit details
    Browse the repository at this point in the history

  2. Apply Review suggestion: deconstruct explicitly handle.

    @darnuria
    darnuria committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    092ab54 View commit details
    Browse the repository at this point in the history

  3. Fixup documentation of the OPENED_ENV. 

    Precise that Handle open the file.
    @darnuria
    darnuria committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ded5dd8 View commit details
    Browse the repository at this point in the history

  4. Review: we don't need canonnicalize anymore.

    @darnuria
    darnuria committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    86da304 View commit details
    Browse the repository at this point in the history

  5. Fix hardlink test.

    @darnuria
    darnuria committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    295d159 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. fixup! document path changes

    @darnuria
    darnuria committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d720f09 View commit details
    Browse the repository at this point in the history

  2. Fixup! Hardlink will not work reviewed my unixbasics

    @darnuria
    darnuria committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b065e91 View commit details
    Browse the repository at this point in the history

  3. Fixup! Integrate suggestion from review about the tests.

    @darnuria
    darnuria committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    641d229 View commit details
    Browse the repository at this point in the history

  4. Fix symlink no subdir

    @darnuria
    darnuria committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    833e433 View commit details
    Browse the repository at this point in the history

  5. Fix windows details.

    @darnuria
    darnuria committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    911ba89 View commit details
    Browse the repository at this point in the history

  6. Windows moving dir is just a burden.

    @darnuria
    darnuria committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    83b4386 View commit details
    Browse the repository at this point in the history