Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of ReservedSpace #260

Merged
merged 5 commits into from
May 6, 2024

Conversation

nolanderc
Copy link
Contributor

Pull Request

Related issue

Addresses (some) concerns raised in a comment: #256 (review).

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
    • Where can I find these?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

I looked at the investigation and it seems the fastest implementation is the put-reserved-uninit method. What do you think?

Ho! And BTW, don't worry about the contribution guideline, this template is from the Meilisearch repo 😃

heed/src/reserved_space.rs Show resolved Hide resolved
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are really a beast 🐻 That's amazing work!

@Kerollmops Kerollmops merged commit 522cf8c into meilisearch:main May 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants