Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes regarding Meilisearch v0.26.0 #181

Closed
curquiza opened this issue Feb 9, 2022 · 7 comments
Closed

Changes regarding Meilisearch v0.26.0 #181

curquiza opened this issue Feb 9, 2022 · 7 comments
Labels
Meilisearch bump Changes related to the Meilisearch bump version

Comments

@curquiza
Copy link
Member

curquiza commented Feb 9, 2022

This issue gathers the changes related to the v0.26.0 of Meilisearch that will impact the integrations.

Release date: 14/03/2022

The whole milestones of v0.26.0 here: https://github.com/meilisearch/meilisearch/milestones/27


New flag behavior

Related to meilisearch/meilisearch#2097

It means every --no-analytics=true are now --no-analytics

This impacts every integration in our

  • CIs
  • examples in CONTRIBUTING.md
  • some docker-compose files if they exist

⚠️ We will try to automate most part of the work with octopus (internal tool), but please, check no --analytics=true has been forgotten.

New dump behavior

Related to

Some changes impact meilisearch-migration.

Two changes in v0.26.0:

  • When importing a dump using --import-dump if a database already exists, an error message will be thrown on the CLI.
  • Similar to the behavior of the snapshot feature. The flags --ignore-dump-if-db-exists and --ignore-missing-dump are added. -> does not impact meilisearch-migration if I'm correct.

Tenant tokens

Related to:

We have to add a generateToken method to every SDK following the spec requirement to make it easy to generate the token for the future search of the user.

Some instruction

  • for the JS SDK -> only implementing for Node.js, not for front-end.
  • As first, try not to use any other library, but if it's not possible, use the most appropriate one.
  • Maybe this will need discussion to find the most user-friendly way to provide the method. Should stay doable regarding the deadline (4 weeks during the pre-release).

🔥 We should add tests 🔥


TODO:
The PR linked below should be merged

@curquiza curquiza added the Meilisearch bump Changes related to the Meilisearch bump version label Feb 9, 2022
This was referenced Feb 10, 2022
@brunoocasali
Copy link
Member

brunoocasali commented Feb 17, 2022

@brunoocasali, @bidoubiwa, and @alallema decided in an internal meeting:

Regarding the token generation, we should have a method like this:

client.generateTenantToken(Object searchRules, DateTime expiresAt:?, String apiKey:?) => String

ps: expiresAt and apiKey are named/keyword params.

If the language doesn't support named parameters it should use:

client.generateTenantToken(Object searchRules, Object options?) => String

The implementation of the token generation should be done without a library but having one is not "prohibited".
When the apiKey is not present we will use the current apiKey from the MeiliSearchClient instance called the generateTenantToken method.

We also opted to not ask as a parameter the hashing algorithm, we will support out-of-box only HS256. If users want more options, they could raise issues for us.

We will not add too complex validations regarding the searchRules, because they were already defined and maintained inside of the core engine, so it doesn't make sense to replicate this logic inside of each SDK.
To help users with possible errors, we will ask for the core team to improve the search errors when they were related to the tenant token.

@brunoocasali
Copy link
Member

brunoocasali commented Mar 2, 2022

Follow up about validations:

Since we will not be able to cover all the aspects regarding the validations we still need to add some checks in the generateTenantToken implementation:

  • expiresAt: should be in the future, should be in UTC, should be a date/time object, could be null.
  • searchRules: should be a array, hash, hashmap or object.
  • apiKey: should be a string, the parameter could be null since the client has the apiKey already defined.

FYI: @meilisearch/integration-team

@alallema
Copy link
Contributor

alallema commented Mar 2, 2022

  • searchRules: should be a string, array or hash, hashmap, object, should not be a null value.

I don't think searchRules could be a string no?

@bidoubiwa
Copy link
Contributor

searchRules: should be a array or hash, hashmap, object, should not be a null value.

Iike @alallema said. While it is true that it should not be a null, it also should not an integer or boolean etc..
Maybe we should removed the should not be a null and only check if searchRules is the following

array or hash, hashmap, object

@alallema
Copy link
Contributor

alallema commented Mar 7, 2022

Iike @alallema said. While it is true that it should not be a null, it also should not an integer or boolean etc..
Maybe we should removed the should not be a null and only check if searchRules is the following

I agree with @bidoubiwa, I think it would be nice to test the type but depending on the language we can always check if the searchRules are not null in case.

@brunoocasali
Copy link
Member

@alallema @bidoubiwa updated!

meili-bors bot added a commit to meilisearch/meilisearch-ruby that referenced this issue Mar 14, 2022
297: Changes related to the next Meilisearch release (v0.26.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
bors bot added a commit to meilisearch/meilisearch-js that referenced this issue Mar 14, 2022
1154: Changes related to the next Meilisearch release (v0.26.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
bors bot added a commit to meilisearch/meilisearch-php that referenced this issue Mar 14, 2022
292: Changes related to the next Meilisearch release (v0.26.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #296
- #298 
- #297
- #302 

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
bors bot added a commit to meilisearch/meilisearch-python that referenced this issue Mar 14, 2022
407: Changes related to the next Meilisearch release (v0.26.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #410 
- #412
- #415 

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
bors bot added a commit to meilisearch/meilisearch-java that referenced this issue Mar 14, 2022
339: Changes related to the next Meilisearch release (v0.26.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #341 
- #344 
- #345 
- #348

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
bors bot added a commit to meilisearch/meilisearch-dart that referenced this issue Mar 14, 2022
136: Changes related to the next Meilisearch release (v0.26.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
bors bot added a commit to meilisearch/meilisearch-dart that referenced this issue Mar 14, 2022
136: Changes related to the next Meilisearch release (v0.26.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
bors bot added a commit to meilisearch/meilisearch-dotnet that referenced this issue Mar 14, 2022
239: Changes related to the next Meilisearch release (v0.26.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
bors bot added a commit to meilisearch/meilisearch-go that referenced this issue Mar 14, 2022
269: Changes related to the next Meilisearch release (v0.26.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #271 
- #275 
- #276

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
meili-bors bot added a commit to meilisearch/meilisearch-swift that referenced this issue Apr 12, 2022
260: Changes related to the next Meilisearch release (v0.26.0) r=bidoubiwa a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: meili-bors[bot] <89034592+meili-bors[bot]@users.noreply.github.com>
meili-bors bot added a commit to meilisearch/meilisearch-swift that referenced this issue Apr 12, 2022
260: Changes related to the next Meilisearch release (v0.26.0) r=bidoubiwa a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: meili-bors[bot] <89034592+meili-bors[bot]@users.noreply.github.com>
@brunoocasali brunoocasali added the WIP Work in progress issue label Apr 22, 2022
bors bot added a commit to meilisearch/meilisearch-rust that referenced this issue Apr 25, 2022
231: Changes related to the next Meilisearch release (v0.26.0) r=brunoocasali a=meili-bot

Related to this issue: meilisearch/integration-guides#181

This PR:
- gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.26.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.26.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
@brunoocasali brunoocasali removed the WIP Work in progress issue label Apr 26, 2022
@brunoocasali
Copy link
Member

Congratulations @meilisearch/integration-team we made it! 🎉 🎉

🎶 🎵 🎶 🎵 WE ARE THE CHAMPIONS!! 🎶 🎵 🎶 🎵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meilisearch bump Changes related to the Meilisearch bump version
Projects
None yet
Development

No branches or pull requests

4 participants