Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement changes due to implicit index creation #76

Closed
eskombro opened this issue Dec 3, 2020 · 0 comments · Fixed by #74
Closed

Implement changes due to implicit index creation #76

eskombro opened this issue Dec 3, 2020 · 0 comments · Fixed by #74
Assignees
@eskombro
Projects
SDKs & Integrations

Comments

@eskombro
Copy link
Member

eskombro commented Dec 3, 2020

Related to meilisearch/integration-guides#48

  • Change the Getting Started as described in the main issue.
  • get_index() does an HTTP call and is not the main method to use anymore.
  • Add the index() method
  • Add tests for index() method
  • Update get_or_create_index with the new way of using index()
  • Add a fetchPrimaryKey() method to Index class. The attribute primaryKey is not updated when using the index() method: the method does not do any HTTP call. Refer to the limitation section in the main issue.
@eskombro eskombro self-assigned this Dec 3, 2020
@eskombro eskombro added this to Open issues in SDKs & Integrations via automation Dec 3, 2020
@eskombro eskombro linked a pull request Dec 3, 2020 that will close this issue
Changes due to the implicit index creation #74
Merged
@eskombro eskombro mentioned this issue Dec 10, 2020
Merged
@bors bors bot closed this as completed in 854d76e Dec 10, 2020
SDKs & Integrations automation moved this from Open issues to Done Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eskombro eskombro

Labels
None yet
Projects
No open projects
SDKs & Integrations
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes due to the implicit index creation meilisearch/meilisearch-java
1 participant
@eskombro