Add filtering on deleteDocuments for Meilisearch v1.2 #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
force-pushed
the
delete-documents-by-filter-ms-v1.2
branch
2 times, most recently
from
12f64f7
to
eada8aa
Compare
bidoubiwa
changed the title
bidoubiwa
force-pushed
the
delete-documents-by-filter-ms-v1.2
branch
from
eada8aa
to
ce7d1a8
Compare
bidoubiwa
force-pushed
the
delete-documents-by-filter-ms-v1.2
branch
from
ce7d1a8
to
a0aa068
Compare
bidoubiwa
changed the base branch from
bump-meilisearch-v1.2.0
to
get-documents-by-filter-ms-v1.2
| const url = `indexes/${this.uid}/${endpoint}` | ||
|
|
||
| try { | ||
| const task = await this.httpRequest.post(url, params) |
There was a problem hiding this comment.
Does the response of this post method vary?
There was a problem hiding this comment.
I thought it could be only a task.
There was a problem hiding this comment.
It is always a task, but if the request fails it goes to the catch
There was a problem hiding this comment.
So, why do you need to create a new instance of the task? Since it is already returned?
There was a problem hiding this comment.
One is a plain object one is an instance of the Task Class
bidoubiwa
force-pushed
the
get-documents-by-filter-ms-v1.2
branch
from
9c2ec7e
to
2e11694
Compare
|
btw, can you cleanup the commit history? 
|
bidoubiwa
force-pushed
the
get-documents-by-filter-ms-v1.2
branch
from
2e11694
to
37c550b
Compare
bidoubiwa
force-pushed
the
delete-documents-by-filter-ms-v1.2
branch
3 times, most recently
from
3c07b9e
to
c6f42e8
Compare
bidoubiwa
force-pushed
the
get-documents-by-filter-ms-v1.2
branch
from
37c550b
to
d079011
Compare
bidoubiwa
force-pushed
the
get-documents-by-filter-ms-v1.2
branch
from
d079011
to
7f927d0
Compare
bidoubiwa
force-pushed
the
delete-documents-by-filter-ms-v1.2
branch
from
44daf9e
to
bf30887
Compare
bidoubiwa
force-pushed
the
delete-documents-by-filter-ms-v1.2
branch
from
bf30887
to
1be343f
Compare
bidoubiwa
force-pushed
the
get-documents-by-filter-ms-v1.2
branch
from
7f927d0
to
19746b1
Compare
Base automatically changed from
get-documents-by-filter-ms-v1.2
to
bump-meilisearch-v1.2.0
May 29, 2023 12:31
meili-bors bot
added a commit
that referenced
this pull request
Jun 5, 2023
1501: Update version for the next release (v0.33.0) r=bidoubiwa a=meili-bot Release CHANGELOG: This version introduces features released on Meilisearch v1.2.0 🎉 Check out the changelog of [Meilisearch v1.2.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.2.0) for more information on the changes.⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version. ### 🚀 Enhancements - The first parameter of the method `deleteDocuments(params)` now supports two different types. Either an array of document ID's or an object containing a `filter` field. The `filter` field works precisely like the `filter` field used on the `search` method (see [the docs on how to use filters](https://www.meilisearch.com/docs/learn/advanced/filtering#filter-basics)) and lets you determine which documents should be deleted.⚠️ Still, even being supported, the ability to receive an array of document ID's is deprecated and should be changed to an object containing the filter field. #1492 `@bidoubiwa` - `getDocuments(parameters: DocumentsQuery)`, now accepts a new `filter` field to filter the documents you'd like to fetch. The `filter` field works precisely like the `filter` field used on the `search` method (see [the docs on how to use filters](https://www.meilisearch.com/docs/learn/advanced/filtering#filter-basics)). #1493 `@bidoubiwa` These feature requires a Meilisearch server version greater than v1.2. Thanks again to `@bidoubiwa!` 🎉 1504: Update code-samples for v1.2 r=bidoubiwa a=meili-bot _This PR is auto-generated._ Update the code-samples.meilisearch.yml according to the [integration-guides issue](meilisearch/integration-guides#270) for more information and the complete description about what should be done here check that issue. This is the [central issue](meilisearch/integration-guides#261) about the Meilisearch release v1.2 in the integrations. Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the specification: meilisearch/specifications#236
deleteDocumentsnow accepts two types of parameter.filterfield. NEWThe
filterfield works precisely like thefilterfield used on thesearchmethod. See the docs on how to use filters.