Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme broken links fixed #1507

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

roy9495
Copy link
Contributor

@roy9495 roy9495 commented May 31, 2023

Pull Request

Related issue

Fixes #1505

What does this PR do?

  • Fixes broken links in the README.md

PR checklist

Please check if your PR fulfils the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@bidoubiwa
Copy link
Contributor

Thanks a lot for this fix 🙏 We are going to try to fix them in all our integration repos :)

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@bidoubiwa
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 1, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 71c4fa4 into meilisearch:main Jun 1, 2023
5 checks passed
@meili-bot
Copy link
Contributor

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂
Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198

@roy9495
Copy link
Contributor Author

roy9495 commented Jun 1, 2023

Thank you

@roy9495
Copy link
Contributor Author

roy9495 commented Jun 1, 2023

Hi, the link provided here https://discord.com/channels/1006923006964154428/1111273670657200198 can't be accessed.
Thank you

@ghost
Copy link

ghost commented Jun 5, 2023

Hello hello there!
The link should be bringing you to one of our channels in our Discord, if you struggle to access it, it might be because you're not a member of our Discord yet. If that's the case, could I kindly encourage you to join us first and then try again with the link? Here's an invite link: https://discord.gg/cNGBBRmG
Don't hesitate to let me know if that solves the issue or not!

@roy9495
Copy link
Contributor Author

roy9495 commented Jun 5, 2023

Hi, @Luna-meili thank you for the help.
Yes, it's solved the issue.

@ghost
Copy link

ghost commented Jun 5, 2023

fantastic thanks very much!

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links broken in the README
3 participants