Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the jsdoc eslint plugin #1510

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Remove the jsdoc eslint plugin #1510

merged 1 commit into from
Jun 5, 2023

Conversation

amit-ksh
Copy link
Contributor

@amit-ksh amit-ksh commented Jun 4, 2023 •
edited
Loading

Pull Request

Related issue

Fixes #1423

What does this PR do?

  • Uninstall the eslint-plugin-jsdoc dependency.
  • Remove all the jsdoc eslint rules from the .eslintrc.js file.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bidoubiwa
bidoubiwa approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot 🙏

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jun 5, 2023
@bidoubiwa
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 5, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 6d4ae6e into meilisearch:main Jun 5, 2023
5 checks passed
@meili-bot
Copy link
Contributor

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂
Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198

@amit-ksh amit-ksh deleted the remove-jsdoc-eslint-plugin branch June 23, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure eslint rules of jsdoc and tsdoc
3 participants
@amit-ksh @bidoubiwa @meili-bot