-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable limit and offset according to documentation. #1630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already has a test: meilisearch-js/tests/documents.test.ts Line 128 in 12dbd46
Only typescript definition was not set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1630 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 22 22
Lines 850 850
Branches 102 100 -2
=======================================
Hits 829 829
- Misses 20 21 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
1633: Update version for the next release (v0.38.0) r=brunoocasali a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-js to a new version: "v0.38.0" Part of the work of #1631 --- This version introduces features released on Meilisearch v1.7.0 🎉 Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes.⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version. ##⚠️ Breaking changes * Update Node.js versions that are used in tests (#1620) `@flevi29` * `scoreDetails` feature is not experimental anymore. You can directly use `showRankingScoreDetails` during a search without activating the experimental feature 🎉 ## 🚀 Enhancements * `dimensions` field is available to the OpenAi model (#1631) `@nicolasvienot` * Enable limit and offset according to documentation. (#1630) `@reijovosu` Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!