Enable limit and offset according to documentation. #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It already has a test: meilisearch-js/tests/documents.test.ts Line 128 in 12dbd46 Only typescript definition was not set. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1630 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 22 22
Lines 850 850
Branches 102 100 -2
=======================================
Hits 829 829
- Misses 20 21 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
meili-bors bot
added a commit
that referenced
this pull request
Mar 11, 2024
1633: Update version for the next release (v0.38.0) r=brunoocasali a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-js to a new version: "v0.38.0" Part of the work of #1631 --- This version introduces features released on Meilisearch v1.7.0 🎉 Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes.⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version. ##⚠️ Breaking changes * Update Node.js versions that are used in tests (#1620) `@flevi29` * `scoreDetails` feature is not experimental anymore. You can directly use `showRankingScoreDetails` during a search without activating the experimental feature 🎉 ## 🚀 Enhancements * `dimensions` field is available to the OpenAi model (#1631) `@nicolasvienot` * Enable limit and offset according to documentation. (#1630) `@reijovosu` Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!