Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add searchCutoffMs index setting #1643

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add searchCutoffMs index setting #1643

merged 1 commit into from
Apr 18, 2024

Conversation

amit-ksh
Copy link
Contributor

Pull Request

Related issue

Fixes #1639

What does this PR do?

  • Add the SearchCutoffMsSetting type to Settings
  • Add new methods getSearchCutoffMs(), updateSearchCutoffMs() and resetSearchCutoffMs() to Index class
  • Add the tests for the newly added API

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@amit-ksh
Copy link
Contributor Author

⚠️ Note: Tests have not been successfully tested due to the unavailability of the search-cutoff-ms API.

@curquiza curquiza requested a review from mdubus April 17, 2024 11:11
@curquiza
Copy link
Member

Thank you very much for your PR @amit-ksh

@mdubus will review your PR when she's available 😊 (next week probably)

@curquiza curquiza linked an issue Apr 17, 2024 that may be closed by this pull request
[v1.8] New searchCutoffMs index settings #1639
Closed
6 tasks
@mdubus
Copy link
Member

mdubus commented Apr 18, 2024

This looks great, thanks a lot @amit-ksh for taking care of this 🤩 👏

@mdubus mdubus merged commit b017fca into meilisearch:bump-meilisearch-v1.8.0 Apr 18, 2024
4 of 6 checks passed
@curquiza curquiza mentioned this pull request Apr 18, 2024
Closed
6 tasks
@brunoocasali brunoocasali added the enhancement New feature or request label May 6, 2024
@brunoocasali brunoocasali mentioned this pull request May 6, 2024
Merged
meili-bors bot added a commit that referenced this pull request May 6, 2024
@meili-bors @meili-bot
Merge #1648
4475864 
1648: Update version for the next release (v0.39.0) r=brunoocasali a=meili-bot

## 🚀 Enhancements

* feat: hybrid search improvements for v1.8.x (#1647) `@mdubus`
* Add `null` to Embedder type (#1646) `@amit-ksh`
* Add searchCutoffMs index setting (#1643, #1645) `@amit-ksh`
    ```js
    client.index('movies').getSearchCutoffMs()
    client.index('movies').updateSearchCutoffMs(150)
    client.index('movies').resetSearchCutoffMs()
    ```

## ⚙️ Maintenance/misc

* Update ESLint, Prettier, TypeScript and fix/improve their configuration files (#1616) `@flevi29`
* Fix code style after configuration changes (#1638) `@brunoocasali`

Thanks again to `@amit-ksh,` `@brunoocasali,` `@curquiza,` `@flevi29,` `@mdubus,` `@meili-bors[bot]` ! 🎉


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
@cnkang cnkang mentioned this pull request May 27, 2024
Merged
@cnkang cnkang mentioned this pull request Jun 5, 2024
Merged
@amit-ksh amit-ksh deleted the feat/add-searchCutoffMs-index-setting branch June 23, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdubus mdubus mdubus approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.8] New searchCutoffMs index settings
4 participants
@amit-ksh @curquiza @mdubus @brunoocasali