Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rankingScoreThreshold in search #1669

Conversation

the-sinner
Copy link
Contributor

Pull Request

Related issue

Fixes #1665

What does this PR do?

  • Add rankingScoreThreshold in search

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@the-sinner
Copy link
Contributor Author

I have added the error code invalid_search_ranking_score_threshold in types.ts. Is it fine ?

@curquiza curquiza added the enhancement New feature or request label Jun 8, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-sinner
I see we have issue with the style-check CI. Can you fix it?

Thank you so much for being everywhere ❤️

@@ -1010,6 +1011,8 @@ export const ErrorStatusCode = {

/** @see https://www.meilisearch.com/docs/reference/errors/error_codes#invalid_facet_search_facet_query */
INVALID_FACET_SEARCH_FACET_QUERY: 'invalid_facet_search_facet_query',

INVALID_SEARCH_RANKING_SCORE_THRESHOLD:'invalid_search_ranking_score_threshold',
Copy link
Member

@curquiza curquiza Jun 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the error code invalid_search_ranking_score_threshold in types.ts. Is it fine ?

It's fine!

Shouldn't we also add invalid_similar_ranking_score_threshold based on the usage page (last section): https://meilisearch.notion.site/Filter-by-score-usage-224a183ce7b24ca99b6a9a8da755668a

@the-sinner
Copy link
Contributor Author

i have added the other error code as well.
As for the style-check CI, it is running the yarn style, i have run the same command on my local, but it is showing that All matched files use Prettier code style!.
I also tried running yarn style:fix as per Contributing.md, but still showing no changes.

src/types/types.ts Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
@curquiza
Copy link
Member

i have added the other error code as well.
As for the style-check CI, it is running the yarn style, i have run the same command on my local, but it is showing that All matched files use Prettier code style!.
I also tried running yarn style:fix as per Contributing.md, but still showing no changes.

Checking on my side now... Same as you I have no issue. I really don't understand what is happening here 😅

@curquiza curquiza mentioned this pull request Jun 11, 2024
src/types/types.ts Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
@curquiza
Copy link
Member

Finally found the issue! merging!!

@curquiza curquiza merged commit 5f4d297 into meilisearch:bump-meilisearch-v1.9.0 Jun 11, 2024
6 checks passed
@curquiza curquiza mentioned this pull request Jun 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants