Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress does not contain a valid IngressClass #116

Closed
beshkenadze opened this issue May 24, 2022 · 0 comments · Fixed by #117
Closed

Ingress does not contain a valid IngressClass #116

beshkenadze opened this issue May 24, 2022 · 0 comments · Fixed by #117
Labels
enhancement New feature or request

Comments

@beshkenadze
Copy link
Contributor

Description
The nginx controller causes the error "Ignoring ingress because of error while validating ingress class".
The networking.k8s.io/v1 API requires to use the nginx class name.

Expected behavior
Should work.

Current behavior
Doesn't work.

Environment (please complete the following information):

  • Meilisearch version: meilisearch-0.1.33
  • meilisearch-kubernetes version: v1.22.8
@beshkenadze beshkenadze mentioned this issue May 24, 2022
Merged
3 tasks
bors bot added a commit that referenced this issue May 25, 2022
@bors @beshkenadze
Merge #117
dc59df2 
117: Fix ingress does not contain a valid IngressClass r=alallema a=beshkenadze

Add the ingressClassName field  if the k8s version higher then 1.19-0.

See: https://kubernetes.github.io/ingress-nginx/#what-is-an-ingressclass-and-why-is-it-important-for-users-of-ingress-nginx-controller-now

# Pull Request

## What does this PR do?
Fixes #116

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Aleksandr Beshkenadze <beshkenadze@gmail.com>
@bors bors bot closed this as completed in 224d5f8 May 25, 2022
@alallema alallema added the enhancement New feature or request label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ingress does not contain a valid IngressClass beshkenadze/meilisearch-kubernetes
2 participants
@beshkenadze @alallema