-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PVC gets deleted even when persistence is enabled #24
Comments
Interesting, this deserves a little further investigation, as I see here developers having quite the opposite issue
Any insigths @renehernandez ? :) |
I think the issue lies that we are defining a My suspiction is that since we are defining the |
We could either moved the |
I have the same problem. |
Hi @veneliniliev, |
I close this issue due to inactivity, it does not seem to be still present. Feel free to reopen it if the problem is still there. |
I still have a problem. |
We are also facing the same issue. We have the |
any update? |
We had to create our own helm chart to support this and a few other features the current helm chart doesn't support like setting the master key from a secret: https://github.com/factly/helm-charts/tree/main/charts/meilisearch The mount path on the helm chart is also wrong as of today. Another major issue for which I am currently having to use this workaround: meilisearch/meilisearch#2503 (comment) |
Hi @deshetti, |
@alallema |
Hi @veneliniliev, |
I had the same issue described here. This is how I avoided it: I stopped using the helm chart and created a
|
123: Change the mount path with new meili_data path r=alallema a=alallema # Pull Request ## What does this PR do? Following this [issue](meilisearch/meilisearch#2503) and #24 the mount path should be update to allow persistence Co-authored-by: alallema <amelie@meilisearch.com>
Hi @alallema , |
We had to create our own helm chart to and apply changes to support the persistence. Thanks, @deshetti I took the reference from your repo. |
Hi @NishaSharma14, |
any update? |
@veneliniliev I am not here often and I am guessing that you've probably moved on from this, but I will tell you how we danced around this issue. We used a feature of helm that prevents k8s resources from being deleted when uninstalling. (A snippet of our values file, showing how we passed in the annotation) Since the helm chart attempts to create a pvc with the exact same name / configuration each time, adding the annotation will prevent it from being deleted when you uninstall, and when you reinstall, it will discover there is already a pvc with the name in the given namespace with the same configuration, and wont attempt to recreate it. (or at least that is my best understanding of how things were working here... 😅) Hope this helps! |
Hi @churdstheword, |
I have a problem when pod is moved from node to node or GKE is updated. |
If you do not want that Helm deletes your PVC, you must not let Helm mangage the PVC. Just create a PVC by applying a Kubernetes resource and reference it in the |
I installed the helm chart with
persistence.enabled: true
and when I uninstalled the helm chart I see that the PVC was deleted. I would assume that PVC would not be deleted when I uninstall the chart in persistence mode, it should be only be deleted manually.The text was updated successfully, but these errors were encountered: