Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to the next Meilisearch release (v1.1.0) #163

Merged
merged 3 commits into from
May 10, 2023

Conversation

meili-bot
Copy link
Contributor

Related to this issue: meilisearch/integration-guides#251

This PR:

  • gathers the changes related to the next Meilisearch release (v1.1.0) so that this package is ready when the official release is out.
  • should pass the tests against the latest pre-release of Meilisearch.
  • might eventually contain test failures until the Meilisearch v1.1.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.1.0) is out.

This PR is auto-generated for the pre-release week purpose.

@gajus
Copy link

gajus commented May 10, 2023

Is there a particular reason this has not been published despite there being already an official v1.1.0 release?

https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0

@alallema
Copy link
Contributor

Is there a particular reason this has not been published despite there being already an official v1.1.0 release?

https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0

None except that I am very late ... 😅

@gajus
Copy link

gajus commented May 10, 2023

Not great. This is ended up causing a fairly major outage for us.

In our case, the client SDK and API versions were updated to the "latest" version without realizing that they are different versions. Client was using multi- endpoint, which became available only in API v1.1. We first deployed API and confirmed that everything is working. The SDK update has come out business as usual and broke everything middle of the night.

These releases should be done in sync.

@gajus
Copy link

gajus commented May 10, 2023

CC @Kerollmops

@alallema
Copy link
Contributor

Hi @gajus,

These releases should be done in sync.

It's normally the case, but this time I was late, sorry for the inconvenience. I'll make the release as soon as possible

@alallema alallema marked this pull request as ready for review May 10, 2023 16:05
@brunoocasali
Copy link
Member

Hi @gajus, I'm terribly sorry to see that happen to your production env.

We're always making improvements in our internal processes to make sure everything is running smoothly for our users. Unfortunately, the k8s chart was one of the last ones this time, but we're changing that to be one of the first ones to be released.

Meilisearch SDKs follow semver, but in these cases, if you are adopting a new feature you must ensure the new Meilisearch version is also running. We always mention in the SDK release changelogs the Meilisearch compatibility.

Unfortunately, we don't have an automated safeguard in the SDKs that could prevent that from happening as well (I am open to suggestions).

Since every bug report is carefully taken into account, in the next release v1.2 we're going to make sure the k8s chart is on our top priority tiers.

cheers,

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alallema
Copy link
Contributor

bors merge

meili-bors bot added a commit that referenced this pull request May 10, 2023
163: Changes related to the next Meilisearch release (v1.1.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#251

This PR:
- gathers the changes related to the next Meilisearch release (v1.1.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.1.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.1.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Co-authored-by: alallema <amelie@meilisearch.com>
@meili-bors
Copy link
Contributor

meili-bors bot commented May 10, 2023

Build failed:

@alallema alallema merged commit 2201f1b into main May 10, 2023
3 checks passed
@alallema alallema deleted the bump-meilisearch-v1.1.0 branch May 10, 2023 16:38
@gajus
Copy link

gajus commented May 10, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants