This repository has been archived by the owner on May 13, 2021. It is now read-only.
Add tests for search()
method
#81
Labels
Projects
Comments
meilisearch-laravel-scout/tests/MeilisearchEngineTest.php Lines 47 to 63 in 36d40eb
not sure to understand, this one is not enough? |
Maybe I badly understand I was surprised the |
bors bot
added a commit
that referenced
this issue
Mar 2, 2021
102: Add feature tests r=curquiza a=mmachatschek WIP This adds feature tests to the repo and solves #90 and #81 ~~TODOS:~~ - [x] ~~Add documentation how to run feature tests locally~~ - [x] Add more tests (based on https://github.com/meilisearch/meilisearch-symfony/) - [x] Update the cleanup method and add a `SCOUT_PREFIX` config with a test key and only remove indexes with that prefix to avoid deleting documents from a local meilisearch instance ~~I added a matrix for the meilisearch containers to also test the library against older versions. If this should be removed, just tell me @shokme or @curquiza.~~ Co-authored-by: Markus Machatschek <mmachatschek@yahoo.com>
Yes! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If I understand well, we don't have tests for the
search()
method:meilisearch-laravel-scout/src/Engines/MeilisearchEngine.php
Lines 81 to 92 in a66ac4c
We should add tests for this.
Tell me if I'm wrong 🙂
The text was updated successfully, but these errors were encountered: