Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Remove duplicated key on code-samples #520

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

justkahdri
Copy link

@justkahdri justkahdri commented Jun 5, 2023

Pull Request

Hey @brunoocasali, Joaco from the basement team here, found this duplicated key while building meilisearch.com so thought of opening a PR 馃榿

What does this PR do?

  • Removes duplicated key get_documents_1 since it was causing errors on the docs deployment. Removed second examples since it seemed the first one was more useful, but correct me if I'm wrong.
    EDIT: The other get_documents_1 is in line 15.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@justkahdri justkahdri self-assigned this Jun 5, 2023
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! @justkahdri thanks for fixing this!

bors merge

@brunoocasali brunoocasali added the documentation Improvements or additions to documentation label Jun 5, 2023
@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 5, 2023

@meili-bors meili-bors bot merged commit e6a1bf1 into main Jun 5, 2023
8 checks passed
@meili-bors meili-bors bot deleted the joaco/patch-1 branch June 5, 2023 17:50
@meili-bot
Copy link
Contributor

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we鈥檙e holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you鈥檒l automatically join a lottery for a chance at winning some Meiliswag. 馃檪
Don鈥檛 hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants