Ppunk documents fetch fix # #523
Conversation
There was a problem hiding this comment.
Hi @panzer-punk thanks a lot for your bug fix, I just pointed out something that broke the code.
I'm not sure if there is a replacement, please let me know.
src/Contracts/DocumentsQuery.php
Outdated
| * | ||
| * @return array|string|null | ||
| */ | ||
| private function fields(): mixed |
There was a problem hiding this comment.
The mixed broke the implementation it is only introduced in PHP 8 right? So we can't use that, because we still support php 7.4
| private function fields(): mixed | |
| private function fields() |
There was a problem hiding this comment.
@brunoocasali yep, my bad. I'll fix it
|
@brunoocasali removed mixed return type |
There was a problem hiding this comment.
Thanks a lot for your first contribution @panzer-punk 🤘
bors merge
|
Build failed: |
|
bors merge |
|
Canceled. |
|
bors merge |
|
@brunoocasali I'm not sure what's going on, I just tried to sync fork and I might've broken some checks. bors said there is some integration failure with guzzle 7 and php 7.4. Sorry |
|
This message is sent automatically Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle? |
Fixes #522
Fixed behavior for fields if new documents/fetch endpoint used.