Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing native fn invocation #54

Closed
wants to merge 4 commits into from
Closed

Implementing native fn invocation #54

wants to merge 4 commits into from

Conversation

devrck
Copy link
Contributor

@devrck devrck commented Jul 2, 2020 •
edited

  • Applied to all code base
  • Optional: added declare_strict_types since we require PHP 7.2 😄 (I can also remove it if we have a problem)
  • Removed redundant directives from .editorconfig since they are provided from root [*]
  • Moved linting before running tests.

Fixing #53

@devrck devrck marked this pull request as ready for review July 2, 2020 13:58
@curquiza
Copy link
Member

curquiza commented Jul 3, 2020

Hello @devrck, a big refactor #43 was just merged! I hope you are ok with the merged conflicts!

@devrck
Copy link
Contributor Author

devrck commented Jul 3, 2020

Will close & start from there since it's easier 😄 because i will just apply the phpcs.

@devrck devrck closed this Jul 3, 2020
@curquiza
Copy link
Member

curquiza commented Jul 3, 2020

Ok, sorry @devrck! 😅 Thanks!

@devrck devrck mentioned this pull request Jul 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devrck @curquiza