Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send body for get requests #763

Merged
merged 4 commits into from
May 23, 2023
Merged

Don't send body for get requests #763

merged 4 commits into from
May 23, 2023

Conversation

sanders41
Copy link
Collaborator

Pull Request

Related issue

Fixes #762

What does this PR do?

  • Makes it where the body isn't sent with the request if it is empty.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the bug Something isn't working label May 20, 2023
@sanders41 sanders41 changed the title Don't send body if empty Don't send body for get requests May 23, 2023
alallema
alallema approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanders41 🚀
LGTM!

@alallema
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented May 23, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 5d51424 into main May 23, 2023
10 checks passed
@meili-bors meili-bors bot deleted the http branch May 23, 2023 13:59
@alallema alallema mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meilisearch is sending a body on GET requests
2 participants
@sanders41 @alallema