Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for attributes to search on #806

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

sanders41
Copy link
Collaborator

Pull Request

This will most likely have a merge conflict with #805. I can resolve with which ever merges first.

Related issue

Fixes #<issue_number>

What does this PR do?

  • Add test for attributes to search on

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the skip-changelog The PR will not appear in the release changelogs label Jul 19, 2023
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@alallema alallema merged commit f8b45a8 into bump-meilisearch-v1.3.0 Jul 28, 2023
10 checks passed
@alallema alallema deleted the attributes-to-search-on branch July 28, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants