Add testing for Python 3.12 #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #859 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 721 721
=========================================
Hits 721 721 ☔ View full report in Codecov by Sentry. |
Will do it! |
curquiza
added
the
maintenance
|
@sanders41 looks like there are merge conflict and so I cannot merge the branch |
|
@curquiza I merged main and it didn't show me any conflicts...we will see if the merge is enough |
Done ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Python 3.12 is scheduled for release today so this PR adds 3.12 to the test matrix. The release has not been completed yet so tests will fail until that happens. I have tested locally with the RC and all tests pass.
We also need to add 3.12 to the required tests in the GitHub settings once the release happens and this comes out of draft.
Related issue
Fixes #<issue_number>
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!