Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support text separator customization #871

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Support text separator customization #871

merged 5 commits into from
Oct 24, 2023

Conversation

ellnix
Copy link
Contributor

@ellnix ellnix commented Oct 24, 2023

Pull Request

Related issue

Fixes #852

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d8b4ad) 100.00% compared to head (98168cf) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #871   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          730       748   +18     
=========================================
+ Hits           730       748   +18
Files Coverage Δ
meilisearch/config.py 100.00% <100.00%> (ø)
meilisearch/index.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sanders41
sanders41 requested changes Oct 24, 2023
View reviewed changes
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
meilisearch/index.py Outdated Show resolved Hide resolved
meilisearch/index.py Outdated Show resolved Hide resolved
tests/settings/test_settings_text_separators_meilisearch.py Show resolved Hide resolved
@ellnix ellnix force-pushed the support-text-separator-customization branch from 2f0fd09 to 98168cf Compare October 24, 2023 14:13
sanders41
sanders41 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry again for the confusion on the None thing.

@sanders41
Copy link
Collaborator

bors merge

@sanders41 sanders41 added the enhancement New feature or request label Oct 24, 2023
@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 24, 2023

Build succeeded:

@ellnix ellnix closed this Oct 24, 2023
@meili-bors meili-bors bot merged commit 1c4ce20 into meilisearch:main Oct 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanders41 sanders41 sanders41 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.4] Support text-separator customization
2 participants
@ellnix @sanders41