New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible sanitization change leads to a unexpected behavior on integration_spec #98

Closed

brunoocasali opened this issue Jan 7, 2022 · 1 comment

Labels

bug good first issue

Member

brunoocasali commented Jan 7, 2022

Description
According to @jitingcn we are facing an issue regarding a possible change in the rails sanitizer.

We need to dig into that to understand better why this changed and if it affects any other part of the integration.
We could use this time to refactor that particular spec in order to explicitly tell the reader which version of rails is responsible for what behavior, today we have flow control by using exceptions and this could be improved to be more clear 🥇

Expected behavior
No exception should be raised.

Current behavior
An exception is being raised.

brunoocasali added bug good first issue labels

brunoocasali mentioned this issue

Upgrade rspec version to 3.x #94

Merged

brunoocasali added the hacktoberfest label

curquiza removed the hacktoberfest label

Member Author

brunoocasali commented Aug 21, 2023

Since we have received no new report about that in years, I'm closing this issue. Just let me know if this issue is still a thing.

brunoocasali closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment