Skip to content

Upgrade rspec version to 3.x #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 10, 2022
Merged

Upgrade rspec version to 3.x #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2bb6211
Convert specs to RSpec 2.99.2 syntax with Transpec
jitingcn Dec 21, 2021
1b19a3e
Bump rspec version
jitingcn Dec 21, 2021
7907ff1
Fix rescue
jitingcn Dec 21, 2021
cc2f757
Fix RuboCop RSpec/MultipleExpectations
jitingcn Dec 21, 2021
f2325c5
Fix rubocop errors
jitingcn Jan 7, 2022
f1bfd37
Merge branch 'main' into rspec-3-upgrade
jitingcn Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Style/FrozenStringLiteralComment:
Enabled: false

RSpec/MultipleExpectations:
Max: 5
Enabled: false

Metrics/BlockLength:
Enabled: true
Expand Down
22 changes: 11 additions & 11 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2021-11-18 14:59:50 UTC using RuboCop version 1.23.0.
# on 2022-01-07 22:37:10 UTC using RuboCop version 1.24.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -24,6 +24,7 @@ Layout/BlockAlignment:

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Layout/CommentIndentation:
Exclude:
- 'lib/meilisearch-rails.rb'
Expand Down Expand Up @@ -63,12 +64,6 @@ Lint/UnusedMethodArgument:
Exclude:
- 'lib/meilisearch-rails.rb'

# Offense count: 15
Copy link
Member

@brunoocasali brunoocasali Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👏

# Configuration parameters: CheckForMethodsWithNoSideEffects.
Lint/Void:
Exclude:
- 'spec/integration_spec.rb'

# Offense count: 10
# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
Metrics/AbcSize:
Expand Down Expand Up @@ -187,12 +182,11 @@ Style/GuardClause:
Exclude:
- 'lib/meilisearch-rails.rb'

# Offense count: 9
# Offense count: 8
# Cop supports --auto-correct.
Style/IfUnlessModifier:
Exclude:
- 'lib/meilisearch-rails.rb'
- 'spec/integration_spec.rb'

# Offense count: 1
# Cop supports --auto-correct.
Expand All @@ -201,6 +195,12 @@ Style/InverseMethods:
Exclude:
- 'lib/meilisearch-rails.rb'

# Offense count: 2
# Cop supports --auto-correct.
Style/MapToHash:
Exclude:
- 'lib/meilisearch-rails.rb'

# Offense count: 8
# Configuration parameters: AllowedMethods.
# AllowedMethods: respond_to_missing?
Expand All @@ -214,9 +214,9 @@ Style/RescueModifier:
Exclude:
- 'lib/meilisearch-rails.rb'

# Offense count: 10
# Offense count: 11
# Cop supports --auto-correct.
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Layout/LineLength:
Max: 264
Max: 269
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ group :test do
gem 'activerecord-jdbc-adapter', platform: :jruby
gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby
gem 'jdbc-sqlite3', platform: :jruby
gem 'rspec', '>= 2.5.0', '< 3.0'
gem 'rspec', '~> 3.0'
gem 'simplecov', require: 'false'

gem 'byebug'
Expand Down
Loading