Document multi search usage #344
Conversation
|
I will try to make a new release as soon as this is merged, since otherwise we will have a section of the README that does not work in production. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
=======================================
Coverage 90.22% 90.22%
=======================================
Files 13 13
Lines 757 757
=======================================
Hits 683 683
Misses 74 74 ☔ View full report in Codecov by Sentry. |
README.md
Outdated
| @@ -240,6 +241,58 @@ Book.search('*', sort: ['title:asc']) | |||
|
|
|||
| 👉 Don't forget to set up the `sortable_attributes` option in the `meilisearch` block of your model. | |||
|
|
|||
| ## 🔍🔍 Multi search | |||
|
|
|||
| MeiliSearch supports searching multiple models at the same time (see [🔍 Custom search](#-custom-search) for search options): | |||
There was a problem hiding this comment.
| MeiliSearch supports searching multiple models at the same time (see [🔍 Custom search](#-custom-search) for search options): | |
| Meilisearch supports searching multiple models at the same time (see [🔍 Custom search](#-custom-search) for search options): |
There was a problem hiding this comment.
Ooops sorry, old habits die hard lol
There was a problem hiding this comment.
hahaha no issue!
Also, if you have time you could put in your big breaking changing the main class name to Meilisearch instead of MeiliSearch. Not only here but in the ruby gem as well.
There was a problem hiding this comment.
That should be easy, just a find and replace. But it will be a huge breaking change, possibly v1?
There was a problem hiding this comment.
I don't want to think about making a v1 right now, especially since we will introduce a lot of new stuff. Let's do all the breaking and wait for them to sink into the users. Also we will be able to understand if the changes had the effect we wanted :)
ellnix
force-pushed
the
document-multi-search-usage
branch
from
1ca6812
to
37c894c
Compare
Fixes #337