Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the usage of the camelCase attributes #320

Closed
3 tasks
brunoocasali opened this issue Apr 26, 2022 · 1 comment
Closed
3 tasks

Deprecate the usage of the camelCase attributes #320

brunoocasali opened this issue Apr 26, 2022 · 1 comment
Labels
breaking-change The related changes are breaking for the users good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

brunoocasali commented Apr 26, 2022

We currently support multiple ways of sending the search attributes:

  • index.search('abc', { attributesToCrop: ['description'], cropLength: 5 })
  • index.search('abc', { attributes_to_highlight: ['description'] })

and incorrect and weird ways like:

  • index.search('abc', { distinct_ATTribute: 'title' })

Since this is not a ruby style of having attributes, we should eliminate it!

TODO:

  • Print warning messages when the user called a method with a different typographical convention than snake_case.
  • Replace the old way with the new way in the .code-samples.meilisearch.yml

After the two initial steps:

  • Drop the support to other styles (removing the code and the warnings).
@brunoocasali
Copy link
Member Author

Fixed by #377 and #470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant