Add new search parameters highlightPreTag, highlightPostTag and cropMarker #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
reviewed
Apr 26, 2022
Member
There was a problem hiding this comment.
- Why not do the test in the ruby-friendly way, I mean with snake case instead of camel case? 😇
- Also, it's not clear in the PR description the parameter are supported by default by the package and only tests are added in this PR. I suppose you put the
enhancementlabel to let the user understand this new release is compatible withcropMarker... but we have to be clear regarding the PR, otherwise it could be confused if the user goes to the PR.
bidoubiwa
suggested changes
Apr 26, 2022
brunoocasali
force-pushed
the
add-nested-fields-support
branch
2 times, most recently
from
db5df23 to
6904b51
Compare
Base automatically changed from
add-nested-fields-support
to
bump-meilisearch-v0.27.0
April 26, 2022 17:43
brunoocasali
force-pushed
the
add-crop-and-highlight
branch
from
21ea0c0 to
70d972f
Compare
brunoocasali
force-pushed
the
add-crop-and-highlight
branch
from
70d972f to
635d96c
Compare
Member
Author
Yeah, I have run out of hair because of it, but for now, is ok to keep it because is consistent with the other tests present in this file. In any case, I'll open an issue about it! |
Member
Author
|
Issue about camel casing is open #320 |
Member
Author
|
@curquiza and @bidoubiwa I'll merge it, but feel free to make comments! |
brunoocasali
added a commit
that referenced
this pull request
May 5, 2022
meili-bors bot
added a commit
that referenced
this pull request
May 9, 2022
323: Update version for the next release (v0.18.3) r=curquiza a=brunoocasali This version makes this package compatible with Meilisearch v0.27.0 🎉 Check out the changelog of [Meilisearch v0.27.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.27.0) for more information on the changes. ## 🚀 Enhancements * Ensure nested field support (#318) `@brunoocasali` * Add `highlightPreTag`, `highlightPostTag`, `cropMarker`, parameters in the search request (#319) `@brunoocasali` * Create a helper module to reduce test duplication (#316) `@brunoocasali` ## 🐛 Bug Fixes * Improve error handling, rescue EPIPE and Net::* errors (#307) `@brunoocasali` Thanks again to `@brunoocasali!` 🎉 Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per meilisearch/meilisearch#2214 new search parameters are introduced:
highlightPreTaghighlightPostTagcropMarkerThis PR adds tests to ensure the new parameters are working.