Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5] Add a new method for creating snapshots #504

Closed
2 tasks
brunoocasali opened this issue Nov 20, 2023 · 0 comments · Fixed by #508
Closed
2 tasks

[v1.5] Add a new method for creating snapshots #504

brunoocasali opened this issue Nov 20, 2023 · 0 comments · Fixed by #508
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

⚠️ This issue is generated, it means the examples and the namings do not necessarily correspond to the language of this repository.
Also, if you are a maintainer, feel free to add any clarification and instruction about this issue.

Sorry if this is already partially/completely implemented, feel free to let me know about the state of this issue in the repo.

Related to meilisearch/integration-guides#290


This issue is divided in two sections, first you need to make the implementation, second you must update the code-samples (no one likes a outdated docs, right?).

New implementation

Related to:

Add a method createSnapshot similar to createDump() to call the newly introduced POST /snapshots route and return a task.

👉 Usage: https://www.notion.so/meilisearch/Usage-On-demand-snapshots-f105c94abb444b61a9d0f94550a5199e

Code samples:

Inside of this file: .code-samples.meilisearch.yml:

  1. Create a new entry with this key create_snapshot_1: containing a call to the createSnapshot() method.

Use this as a reference if the previous description was not helpful:

create_snapshot_1: |-
  curl \
  -X POST 'http://localhost:7700/snapshots'

Todo:

  • Implement the new createSnapshot method
  • Update the code-samples according to this issue.
@brunoocasali brunoocasali added enhancement New feature or request good first issue Good for newcomers labels Nov 20, 2023
meili-bors bot added a commit that referenced this issue Jan 17, 2024
508: Add method for creating a snapshot r=ellnix a=andre-m-dev

# Pull Request

## Related issue
Fixes [504](#504)

## What does this PR do?
- Add a method to create a snapshot

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: Andre <>
Co-authored-by: André <1729839+andre-m-dev@users.noreply.github.com>
meili-bors bot added a commit that referenced this issue Jan 17, 2024
508: Add method for creating a snapshot r=ellnix a=andre-m-dev

# Pull Request

## Related issue
Fixes [504](#504)

## What does this PR do?
- Add a method to create a snapshot

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: Andre <>
Co-authored-by: André <1729839+andre-m-dev@users.noreply.github.com>
@meili-bors meili-bors bot closed this as completed in #508 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant