Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete_index_if_exists method #232

Merged
merged 4 commits into from Oct 12, 2021

Conversation

toshitapandey
Copy link
Contributor

@toshitapandey toshitapandey commented Oct 7, 2021

Purpose
  • Add delete_index_if_exists method to not raise error when index mentioned in argument doesn't exist
  • Test cases for same

Closes #228

@CaroFG
Copy link
Contributor

CaroFG commented Oct 11, 2021

Hi @toshitapandey! Thank you so much for this PR! Could you please run the linter and correct the errors? Check the dedicated section of the contributing guide 🙏

@toshitapandey
Copy link
Contributor Author

Hey @CaroFG! The linter issues have been resolved. Pls, take a look.

Copy link
Contributor

@CaroFG CaroFG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @toshitapandey!

If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 12, 2021

@bors bors bot merged commit 8256f44 into meilisearch:main Oct 12, 2021
@curquiza curquiza added the enhancement New feature or request label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a method to delete the index only if it already exists
3 participants