Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove get_or_create_index method #277

Merged
merged 1 commit into from Dec 21, 2021
Merged

Remove get_or_create_index method #277

merged 1 commit into from Dec 21, 2021

Conversation

curquiza
Copy link
Member

Why?

The first goal of this method was to avoid raising an instant error when trying to create an index that already exists.
Since MeiliSearch v0.25.0, the index creation is asynchronous and will not raise any instant error anymore.

@curquiza curquiza added the breaking-change The related changes are breaking for the users label Dec 21, 2021
@curquiza curquiza merged commit e6acfa1 into bump-meilisearch-v0.25.0 Dec 21, 2021
@curquiza curquiza deleted the remove-getorcreate branch December 21, 2021 14:45
@curquiza curquiza mentioned this pull request Jan 12, 2022
Merged
meili-bors bot added a commit that referenced this pull request Jan 12, 2022
@meili-bors @curquiza
Merge #289
5f282ef 
289: Update version for the next release (v0.18.0) r=brunoocasali a=curquiza

Why is it breaking?
- #276
- #277
- #278
- #273

Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@curquiza