Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typo tolerance customization settings #350

Merged
merged 1 commit into from Jul 27, 2022
Merged

Add typo tolerance customization settings #350

merged 1 commit into from Jul 27, 2022

Conversation

voloyev
Copy link
Contributor

@voloyev voloyev commented Jul 26, 2022

Pull Request

What does this PR do?

Fixes #313

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

brunoocasali
brunoocasali requested changes Jul 26, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @voloyev, thanks a lot for your contribution!

I would like you to add some small things to make this PR perfect, do you mind?

Thanks for contributing with Meilisearch 👨‍🎤

spec/meilisearch/index/settings_spec.rb Outdated Show resolved Hide resolved
spec/meilisearch/index/settings_spec.rb Outdated Show resolved Hide resolved
spec/meilisearch/index/settings_spec.rb Outdated Show resolved Hide resolved
lib/meilisearch/index.rb Outdated Show resolved Hide resolved
@voloyev
Copy link
Contributor Author

voloyev commented Jul 26, 2022

Hello @voloyev, thanks a lot for your contribution!

I would like you to add some small things to make this PR perfect, do you mind?

Thanks for contributing with Meilisearch 👨‍🎤

Hello! I'm do not mind☺️

@voloyev
Copy link
Contributor Author

voloyev commented Jul 26, 2022

@brunoocasali Do I need to squash the commits?

@brunoocasali
Copy link
Member

@brunoocasali Do I need to squash the commits?

You can do it if you want, (I prefer to be honest), but it is not a requirement :)

@voloyev
Copy link
Contributor Author

voloyev commented Jul 26, 2022

@brunoocasali Do I need to squash the commits?

You can do it if you want, (I prefer to be honest), but it is not a requirement :)

Will do then later today

@brunoocasali
Use transform_attributes in update method
1cb57fb 
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
@voloyev
Copy link
Contributor Author

voloyev commented Jul 27, 2022 •
edited

@brunoocasali Do I need to squash the commits?

You can do it if you want, (I prefer to be honest), but it is not a requirement :)

Will do then later today

Updated. @brunoocasali Pls review

brunoocasali
brunoocasali approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing with Meilisearch ❤️

@brunoocasali
Copy link
Member

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 27, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit 61b61e8 into meilisearch:main Jul 27, 2022
@brunoocasali brunoocasali mentioned this pull request Jul 29, 2022
Merged
@brunoocasali brunoocasali added the enhancement New feature or request label Jul 29, 2022
meili-bors bot added a commit that referenced this pull request Aug 1, 2022
@meili-bors @brunoocasali
Merge #353
606f684 
353: Add code samples to faceting and pagination r=brunoocasali a=brunoocasali

Add code samples for the code implemented #352, #350 and #344

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to the typo tolerance customization
2 participants
@voloyev @brunoocasali