Add csv delimiter to Index#add_documents_csv method
#429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
approved these changes
Mar 30, 2023
Unfortunately, the rubocop rules are always affected, even with minimal change, because we are infringing the main rules like class and method sizes. Without a significant refactor, this will be endless. |
meili-bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
432: Update version for the next release (v0.23.0) r=bidoubiwa a=meili-bot This version introduces features released on Meilisearch v1.1.0 🎉 Check out the changelog of [Meilisearch v1.1.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0) for more information on the changes. ### 🚀 Enhancements - Add a new optional argument to `add_documents_csv`. This argument allows you to customize the separator character in your `csv` file. (#429) `@brunoocasali.` - Add `client.multi_search()` method to execute multiple search requests simultaneously with different configurations. (#430) `@brunoocasali` Usage example: ```ruby client.multi_search([ { index_uid: 'books', q: 'prince' }, { index_uid: 'movies', q: 'prince' }, ]) ```⚠️ The `SearchQuery` was not meant to be used if the regular `$index->search()` requests (yet). Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
meili-bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
425: Changes related to the next Meilisearch release (v1.1.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#251 This PR: - gathers the changes related to the next Meilisearch release (v1.1.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v1.1.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.1.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ 432: Update version for the next release (v0.23.0) r=curquiza a=meili-bot This version introduces features released on Meilisearch v1.1.0 🎉 Check out the changelog of [Meilisearch v1.1.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0) for more information on the changes. ### 🚀 Enhancements - Add a new optional argument to `add_documents_csv`. This argument allows you to customize the separator character in your `csv` file. (#429) `@brunoocasali.` - Add `client.multi_search()` method to execute multiple search requests simultaneously with different configurations. (#430) `@brunoocasali` Usage example: ```ruby client.multi_search([ { index_uid: 'books', q: 'prince' }, { index_uid: 'movies', q: 'prince' }, ]) ```⚠️ The `SearchQuery` was not meant to be used if the regular `$index->search()` requests (yet). Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
meili-bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
432: Update version for the next release (v0.23.0) r=curquiza a=meili-bot This version introduces features released on Meilisearch v1.1.0 🎉 Check out the changelog of [Meilisearch v1.1.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0) for more information on the changes. ### 🚀 Enhancements - Add a new optional argument to `add_documents_csv`. This argument allows you to customize the separator character in your `csv` file. (#429) `@brunoocasali.` - Add `client.multi_search()` method to execute multiple search requests simultaneously with different configurations. (#430) `@brunoocasali` Usage example: ```ruby client.multi_search([ { index_uid: 'books', q: 'prince' }, { index_uid: 'movies', q: 'prince' }, ]) ```⚠️ The `SearchQuery` was not meant to be used if the regular `$index->search()` requests (yet). Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
meili-bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
432: Update version for the next release (v0.23.0) r=bidoubiwa a=meili-bot This version introduces features released on Meilisearch v1.1.0 🎉 Check out the changelog of [Meilisearch v1.1.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0) for more information on the changes. ### 🚀 Enhancements - Add a new optional argument to `add_documents_csv`. This argument allows you to customize the separator character in your `csv` file. (#429) `@brunoocasali.` - Add `client.multi_search()` method to execute multiple search requests simultaneously with different configurations. (#430) `@brunoocasali` Usage example: ```ruby client.multi_search([ { index_uid: 'books', q: 'prince' }, { index_uid: 'movies', q: 'prince' }, ]) ```⚠️ The `SearchQuery` was not meant to be used if the regular `$index->search()` requests (yet). Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_documents_csvto allow a different separator.