Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added display hits ranking scores #466

Merged
merged 6 commits into from Aug 17, 2023
Merged

Conversation

andre-m-dev
Copy link
Contributor

@andre-m-dev andre-m-dev commented Aug 14, 2023

Pull Request

Related issue

Fixes #459

What does this PR do?

  • Ensure the SDKs can handle the new search parameter showRankingScore

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the code snake_case? The Ruby SDK can support that :)

Thanks for contributing!

spec/meilisearch/index/search/show_ranking_score_spec.rb Outdated Show resolved Hide resolved
lib/meilisearch/index.rb Outdated Show resolved Hide resolved
spec/meilisearch/index/search/show_ranking_score_spec.rb Outdated Show resolved Hide resolved
andre-m-dev and others added 3 commits August 15, 2023 19:59
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
@andre-m-dev
Copy link
Contributor Author

@brunoocasali thanks for the advice

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ffc6e7) 99.60% compared to head (678092a) 99.60%.

❗ Current head 678092a differs from pull request most recent head 9379c92. Consider uploading reports for the commit 9379c92 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           9        9           
  Lines         508      508           
=======================================
  Hits          506      506           
  Misses          2        2           
Files Changed Coverage Δ
lib/meilisearch/index.rb 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Aug 17, 2023

@meili-bors meili-bors bot merged commit 0e0ae32 into meilisearch:main Aug 17, 2023
6 checks passed
@curquiza curquiza changed the title Added display hits ranking scores [v1.3] Added display hits ranking scores Sep 13, 2023
@curquiza curquiza added the enhancement New feature or request label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3] Display hits ranking scores
4 participants